In 1893, he joined Newton Heath, playing 19 league games and scoring once before joining Luton Town in 1894. He helped Luton gain election to the Football League and played in Luton's first-ever league match on 4 September 1897, a 1–1 draw away to Leicester Fosse. He played 27 times that season, leaving at the end of it to join Barnsley. He scored 3 times in 63 league games for Barnsley before retiring in April 1901 to become Barnsley's secretary-manager.
In 1910 he left St Mirren to take over as manager of Heart of Midlothian.[3][4][5] His spell in Edinburgh encompassed the club's rise to the top of the Scottish League with a group of exciting young players he brought in, and the decimation of that team after they enlisted together to fight in World War I, with several killed and others wounded.[6] The closest he came to silverware was in the 1919 Victory Cup where Hearts were defeated in the final by his old club St Mirren.[3] McCartney resigned from his position in October 1919, and was succeeded as Hearts manager by his son Willie.[7]
In May 1920, he was appointed manager of Portsmouth. He guided Portsmouth from Division Three South to the First Division, but resigned due to ill health in May 1927 before he could manage Pompey in the top flight. In September 1927 he returned to management with Luton Town, but with his health declining further, he resigned in December 1929 and retired from football.
McCartney authored two booklets documenting Scottish footballers in the Great War[8] and those from Hearts who perished.[9] He died in Edinburgh at the age of 66.