Template talk:Junction

Edit request 23 June 2026

Description of suggested change: Remove the vestigial variables statenameModuleName (only initialized and completely unused), missingShields (only initialized to empty and read), allMissingShields (only initialized to empty and read), shieldExistsCache (only initialized to empty and completely unused).

Diff: Special:Diff/1360722589. Note this is not the same starting-point as the published version (I did not want to undo Hike395's change), but the changes are straightforward to port.

Commentary: The existence check is currently fully handled by Module:Road data/parser. An existence check (that does not detect the fallback) should be possible by checking for a nil return on a filename call, but given that the current situation works, there's no point in doing that. Also, there are plenty of nil-checks on the parser return values already and messing with them could break things.

Artoria2e5 🌉 05:25, 23 June 2026 (UTC)Reply

Just cleaned up some other unused aspects myself. Looking at it closer, there seems to be quite a few function parameters that just don't get used (e.g. shieldSpec uses neither mainShield nor shieldList and render doesn't use showLink), as well as one of the functions (render) referencing a global like a local (landscape and "x" or "" - landscape isn't defined anywhere), which makes me somewhat worried these are bugs rather than missed cleanup. Are there any features or anything that's gone missing/broke at any point, or is it safe to assume it's just leftover behaviour and can be cleaned up? Aidan9382 (talk) 22:04, 26 July 2026 (UTC)Reply

Content Disclaimer

Informasi ini disarikan dari Wikipedia dan disajikan kembali untuk tujuan edukasi. Konten tersedia di bawah lisensi CC BY-SA 3.0. Kami tidak bertanggung jawab atas ketidakakuratan data yang bersumber dari kontribusi publik tersebut.

  1. The information displayed on this website is sourced in part or in whole from Wikipedia and has been adapted for the purpose of restating it. We strive to provide accurate and relevant information, however:
  2. There is no guarantee of absolute accuracy. Wikipedia is an open, collaborative project that can be edited by anyone, so information is subject to change.
  3. It is not intended to constitute professional advice. The content displayed is for informational and educational purposes only. For important decisions (e.g., medical, legal, or financial), please consult a professional.
  4. Content copyright. Wikipedia is licensed under the Creative Commons Attribution-ShareAlike License (CC BY-SA). This means that content may be reused with appropriate attribution and shared under a similar license.
  5. Responsible use. Any risk arising from the use of information from this website is entirely the responsibility of the user.