The son of Malcolm Archibald Macdonald, Macdonald was educated at the University of British Columbia and Osgoode Hall. He worked with the Department of Munitions and Supplies in Ottawa during World War II. During that time, he married Dorothy Ann Lewis. After the war, he served as secretary for M. J. Coldwell and then practised law in Ontario for a short time. In 1948, he opened his own practice in Vancouver.[2] He was an unsuccessful candidate in the 1949, 1952, 1953, and 1956 provincial elections.